fix(upgrade): Remove unused getMajorVersion function#5138
Merged
nikosdouvlis merged 3 commits intoFeb 12, 2025
Conversation
🦋 Changeset detectedLatest commit: 0469244 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LekoArts
commented
Feb 12, 2025
| const [configComplete, setConfigComplete] = useState(false); | ||
| const [configVerified, setConfigVerified] = useState(false); | ||
| const [uuid, setUuid] = useState(); | ||
| let fromVersionGuess = false; |
Contributor
Author
There was a problem hiding this comment.
This wasn't used anywhere, so dead code! This is because further down the file there are commented out code bits but I'm sure they are obsolete now, too
LekoArts
marked this pull request as ready for review
February 12, 2025 10:59
nikosdouvlis
approved these changes
Feb 12, 2025
nikosdouvlis
deleted the
lekoarts/eco-403-clerkupgrade-error-in-unused-code
branch
February 12, 2025 11:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A user reported this error while running the upgrade tool on their repo:
This comes from these lines:
clerkwill always beundefinedbecauseread-pkgdoesn't normalize namespaced packages in such a way. It e.g. returns backdependencies: { '@clerk/nextjs': '^5.11.2', 'read-pkg': '^9.0.1' },.But for whatever reason for this user the regex is executed.
Anyways, the function is unused anyways and the desired functionality is already fulfilled by the
guessFrameworksfunction.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change